Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 packages from LexiFi/gen_js_api at 1.1.4 #27070

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

mlasson
Copy link
Contributor

@mlasson mlasson commented Dec 11, 2024

This pull-request concerns:

  • gen_js_api.1.1.4: Easy OCaml bindings for JavaScript libraries
  • ojs.1.1.4: Runtime Library for gen_js_api generated libraries


🐫 Pull-request generated by opam-publish v2.4.0

@avsm
Copy link
Member

avsm commented Dec 11, 2024

The tests are failing; is this expected?


# Error: Cannot find module 'node:fs'
#     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
#     at Function.Module._load (internal/modules/cjs/loader.js:562:25)
#     at Module.require (internal/modules/cjs/loader.js:692:17)
#     at require (internal/modules/cjs/helpers.js:25:18)
#     at new b (/home/opam/.opam/4.14/.opam-switch/build/gen_js_api.1.1.4/_build/default/node-test/test1/test.bc.js:579:14)
#     at /home/opam/.opam/4.14/.opam-switch/build/gen_js_api.1.1.4/_build/default/node-test/test1/test.bc.js:595:83
#     at Object.<anonymous> (/home/opam/.opam/4.14/.opam-switch/build/gen_js_api.1.1.4/_build/default/node-test/test1/test.bc.js:2016:223)
#     at Module._compile (internal/modules/cjs/loader.js:778:30)
#     at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
#     at Module.load (internal/modules/cjs/loader.js:653:32)

@mlasson
Copy link
Contributor Author

mlasson commented Dec 12, 2024

No, this was not expected. Some tests execute the generated code using Node.js. To ensure Node.js is available for running these tests, we include "conf-npm" {with-test} in the opam file.

However, it seems that the following commit introduces compatibility issues with older Node.js versions: ocsigen/js_of_ocaml@dae1e55. The generated code now appears to require a more recent version of Node.js (possibly 14 or 18+).

I will push something that disables the test when the node is too old.

@smorimoto
Copy link
Member

I'm just wondering why they still install node12.

@mlasson mlasson force-pushed the opam-publish-gen_js_api.1.1.4 branch from 9d1ad07 to 0a7dc59 Compare January 16, 2025 14:21
@mlasson
Copy link
Contributor Author

mlasson commented Jan 16, 2025

Do you have to do something to fix the remaining errors ?

@mseri
Copy link
Member

mseri commented Feb 13, 2025

The remaining errors seem spurious. Thanks and sorry for the long wait

@mseri mseri merged commit 27ffb37 into ocaml:master Feb 13, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants