Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] dune (15 packages) (3.17.1) #27137

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

maiste
Copy link
Contributor

@maiste maiste commented Dec 17, 2024

Fast, portable, and opinionated build system

CHANGES:

Fixed

CHANGES:

### Fixed

- When a library declares `(no_dynlink)`, then the `.cmxs` file for it
  is no longer built. (ocaml/dune#11176, @nojb)

- Fix bug that could result in corrupted file copies by Dune, for example when
  using the `copy_files#` stanza or the `copy#` action. (@nojb, ocaml/dune#11194, fixes
  ocaml/dune#11193)

- Remove useless error message when running `$ dune subst` in empty projects.
  (@rgrinberg, ocaml/dune#11204, fixes ocaml/dune#11200)
@maiste maiste mentioned this pull request Dec 17, 2024
11 tasks
@maiste
Copy link
Contributor Author

maiste commented Dec 18, 2024

Regarding the previous run file, it does not seem to be related.

@shonfeder
Copy link
Contributor

shonfeder commented Dec 19, 2024

Auditing the revdeps, the only thing that stood out from the last revdeps failures were the the dream alpha failure, but this is due to #27062.

All else looks good here!

Here are the errors from this time:
dune-3-17-1-revdeps-errors.txt

@maiste also told me everything looked good on his side!

@shonfeder shonfeder merged commit 5c7ffb2 into ocaml:master Dec 19, 2024
2 of 3 checks passed
@maiste maiste deleted the release-dune-3.17.1 branch December 19, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dune subst no longer works on empty directories in ocaml-ci without Dune 3.17
2 participants