-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new release] dream-html (2 packages) (3.9.5) #27194
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for publishing the updates here! Just one question lower bounds failure appearing in CI.
"ocaml" {>= "4.14.0"} | ||
"ppxlib" {>= "0.33.0" & < "1.0.0"} | ||
"pure-html" {= version} | ||
"dream" {>= "1.0.0~alpha7"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only relevant failure in CI is the lowe bounds check failing on
[ERROR] The compilation of dream.1.0.0~alpha7 failed at "dune build -p dream -j 39".
#=== ERROR while compiling dream.1.0.0~alpha7 =================================#
# context 2.4.0~alpha1~dev | linux/x86_64 | ocaml-base-compiler.5.3.0~beta1 | file:///home/opam/opam-repository
# path ~/.opam/5.3~beta1/.opam-switch/build/dream.1.0.0~alpha7
# command ~/.opam/opam-init/hooks/sandbox.sh build dune build -p dream -j 39
# exit-code 1
# env-file ~/.opam/log/dream-7-e90cf6.env
# output-file ~/.opam/log/dream-7-e90cf6.out
### output ###
# File "src/http/dune", line 21, characters 2-32:
# 21 | dream-httpaf.dream-websocketaf
# ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# Error: Library "dream-httpaf.dream-websocketaf" not found.
# -> required by library "dream.http" in _build/default/src/http
# -> required by _build/default/META.dream
# -> required by _build/install/default/lib/dream/META
# -> required by _build/default/dream.install
# -> required by alias install
Since you know dream quite well, iiuc, do you know if this is a packaging error on the side of dream? Could it be avoided for your package perhaps just by raising the lower bound to dream alpha8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I think this is because of #27062. Sure, we can try bumping the lower bound.
New interesting error: https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/db06a38451497a69e56f83d52f7ed317cb347eeb/variant/compilers,4.14,dream-html.3.9.5,lower-bounds
And:
Which is allowed because dream wants version <0.13.0. But it uses |
In ocaml#27194 (comment) we noticed a CI build breakage caused by dream-httpaf not setting a lower bound on the `h2` package. Setting it here.
HTML generator eDSL for Dream
CHANGES:
See https://github.com/yawaramin/dream-html/tags