Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x-maintenance-intent for Irmin packages #27217

Merged
merged 2 commits into from
Jan 12, 2025

Conversation

art-w
Copy link
Contributor

@art-w art-w commented Jan 6, 2025

The deprecated irmin-mem and irmin-unix packages were moved to the main irmin package some time ago (under irmin.mem and irmin.unix).

@hannesm
Copy link
Member

hannesm commented Jan 6, 2025

Thanks! :)

for imin-mem and irmin-unix a flags: deprecated in all versions would be fine as well, but the x-maintenance-intent: [ "(none)" ] is good as well.

There's no need for specifying the x-reason-for-archival, this will be added when the package(s) are moved to opam-repository-archive.

@art-w
Copy link
Contributor Author

art-w commented Jan 6, 2025

Ok sure! Thanks for the clarifications :)

@mseri
Copy link
Member

mseri commented Jan 8, 2025

Thanks

@hannesm
Copy link
Member

hannesm commented Jan 8, 2025

I don't think the last commit (adding sources to irmin-unix) is necessary -- since back then irmin used optional dependencies, and the irmin-unix was just a package depending on irmin and the optional dependencies to get irmin.unix built -- i.e. irmin-unix didn't install anything (and there's no ocamlfind package for irmin-unix) -- so no sources are necessary.

@art-w art-w force-pushed the irmin-maintenance-intent branch from 686f27e to d7c54ec Compare January 8, 2025 11:52
@art-w
Copy link
Contributor Author

art-w commented Jan 8, 2025

Yeah hm you're right I removed that last commit.

Copy link
Contributor

@shonfeder shonfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shonfeder shonfeder merged commit 5e03a85 into ocaml:master Jan 12, 2025
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants