-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[new release] tinyfiledialogs (1.0) #28456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
shonfeder
merged 1 commit into
ocaml:master
from
CharlesAverill:release-tinyfiledialogs-v1.0
Sep 13, 2025
Merged
[new release] tinyfiledialogs (1.0) #28456
shonfeder
merged 1 commit into
ocaml:master
from
CharlesAverill:release-tinyfiledialogs-v1.0
Sep 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90c1831 to
818ee1c
Compare
jmid
reviewed
Sep 7, 2025
818ee1c to
3c28363
Compare
jmid
reviewed
Sep 8, 2025
cc671f5 to
addfa26
Compare
jmid
reviewed
Sep 11, 2025
jmid
reviewed
Sep 11, 2025
CHANGES: Initial release
addfa26 to
b4b6b8a
Compare
jmid
approved these changes
Sep 12, 2025
Member
jmid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now passing on everything but Windows, where it is failing with
[ERROR] The compilation of tinyfiledialogs.1.0 failed at "dune build -p tinyfiledialogs -j 3 @install".
#=== ERROR while compiling tinyfiledialogs.1.0 ================================#
# context 2.4.1 | win32/x86_64 | ocaml.5.3.0 | file://D:/a/opam-repository/opam-repository
# path D:\opamroot\default\.opam-switch\build\tinyfiledialogs.1.0
# command D:\opamroot\default\bin\dune.exe build -p tinyfiledialogs -j 3 @install
# exit-code 1
# env-file D:\opamroot\log\tinyfiledialogs-5832-23816e.env
# output-file D:\opamroot\log\tinyfiledialogs-5832-23816e.out
### output ###
# tinyfiledialogs/tinyfiledialogs.c:328:45: warning: unknown conversion type character 'h' in format [-Wformat=]
# [...]
# | ^
# tinyfiledialogs/tinyfiledialogs.c:328:51: warning: unknown conversion type character 'h' in format [-Wformat=]
# 328 | sprintf(aoResultHexRGB, "#%02hhx%02hhx%02hhx", aRGB[0], aRGB[1], aRGB[2]);
# | ^
# tinyfiledialogs/tinyfiledialogs.c:328:33: warning: too many arguments for format [-Wformat-extra-args]
# 328 | sprintf(aoResultHexRGB, "#%02hhx%02hhx%02hhx", aRGB[0], aRGB[1], aRGB[2]);
# | ^~~~~~~~~~~~~~~~~~~~~
# tinyfiledialogs/tinyfiledialogs.c: In function 'windowsVersion':
# tinyfiledialogs/tinyfiledialogs.c:550:26: warning: cast between incompatible function types from 'FARPROC' {aka 'long long int (*)()'} to 'NTSTATUS (*)(struct _OSVERSIONINFOW *)' {aka 'long int (*)(struct _OSVERSIONINFOW *)'} [-Wcast-function-type]
# 550 | lFxPtr = (RtlGetVersionPtr)GetProcAddress(hMod, "RtlGetVersion");
# | ^
There's too little detail for me to tell whether this is hiding the actual error - or fails because of warnings-as-errors.
I therefore believe this is good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCaml bindings to tinyfiledialogs
CHANGES:
Initial release