Skip to content

Conversation

@CharlesAverill
Copy link
Contributor

OCaml bindings to tinyfiledialogs

CHANGES:

Initial release

@CharlesAverill CharlesAverill force-pushed the release-tinyfiledialogs-v1.0 branch 4 times, most recently from 90c1831 to 818ee1c Compare September 7, 2025 20:05
@CharlesAverill CharlesAverill force-pushed the release-tinyfiledialogs-v1.0 branch from 818ee1c to 3c28363 Compare September 7, 2025 22:36
@CharlesAverill CharlesAverill force-pushed the release-tinyfiledialogs-v1.0 branch 2 times, most recently from cc671f5 to addfa26 Compare September 11, 2025 21:38
CHANGES:

Initial release
@CharlesAverill CharlesAverill force-pushed the release-tinyfiledialogs-v1.0 branch from addfa26 to b4b6b8a Compare September 12, 2025 03:11
Copy link
Member

@jmid jmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now passing on everything but Windows, where it is failing with

  [ERROR] The compilation of tinyfiledialogs.1.0 failed at "dune build -p tinyfiledialogs -j 3 @install".
  
  #=== ERROR while compiling tinyfiledialogs.1.0 ================================#
  # context     2.4.1 | win32/x86_64 | ocaml.5.3.0 | file://D:/a/opam-repository/opam-repository
  # path        D:\opamroot\default\.opam-switch\build\tinyfiledialogs.1.0
  # command     D:\opamroot\default\bin\dune.exe build -p tinyfiledialogs -j 3 @install
  # exit-code   1
  # env-file    D:\opamroot\log\tinyfiledialogs-5832-23816e.env
  # output-file D:\opamroot\log\tinyfiledialogs-5832-23816e.out
  ### output ###
  # tinyfiledialogs/tinyfiledialogs.c:328:45: warning: unknown conversion type character 'h' in format [-Wformat=]
  # [...]
  #       |                                             ^
  # tinyfiledialogs/tinyfiledialogs.c:328:51: warning: unknown conversion type character 'h' in format [-Wformat=]
  #   328 |         sprintf(aoResultHexRGB, "#%02hhx%02hhx%02hhx", aRGB[0], aRGB[1], aRGB[2]);
  #       |                                                   ^
  # tinyfiledialogs/tinyfiledialogs.c:328:33: warning: too many arguments for format [-Wformat-extra-args]
  #   328 |         sprintf(aoResultHexRGB, "#%02hhx%02hhx%02hhx", aRGB[0], aRGB[1], aRGB[2]);
  #       |                                 ^~~~~~~~~~~~~~~~~~~~~
  # tinyfiledialogs/tinyfiledialogs.c: In function 'windowsVersion':
  # tinyfiledialogs/tinyfiledialogs.c:550:26: warning: cast between incompatible function types from 'FARPROC' {aka 'long long int (*)()'} to 'NTSTATUS (*)(struct _OSVERSIONINFOW *)' {aka 'long int (*)(struct _OSVERSIONINFOW *)'} [-Wcast-function-type]
  #   550 |                 lFxPtr = (RtlGetVersionPtr)GetProcAddress(hMod, "RtlGetVersion");
  #       |                          ^

There's too little detail for me to tell whether this is hiding the actual error - or fails because of warnings-as-errors.

I therefore believe this is good to go.

@shonfeder shonfeder merged commit bcac5d1 into ocaml:master Sep 13, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants