-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add conf-libclang.21 using a generic configure script #28950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9a77ae4 to
1baa48e
Compare
|
I've opened ocaml/opam-source-archives#55 with the generalized script, which should be reusable for 22, or 16, ..., 20 too, if we need them. |
|
This is all green modulo
It is thus a good step forward to address conf-libclang failures. The PR needs a maintainer to merge ocaml/opam-source-archives#55 |
|
Tests had already run on the file, and it was retrieved and built correctly from the new url |
|
Thanks! |
There is a current issue with
conf-libclangwhich has not evolved as fast as new clang versions are upgraded in distributions.The current
conf-libclang.15is thus failing on several distributions because system packages such aslibclang-15-devare no longer available on a recent distro, causing a downgrade toconf-libclang.12(with unversioned system package constraints) which will instead fail the version check, as "libclang.21 is not in [3;12]".This WIP PR
conf-libclang.21more up to date with distribution versions andopam-source-archivesandopam-repositoryto roll a new version.AFAICS we were already passing the opam
versionvariable toconfigure.shin earlier versions, but not using it? 🤔Here's a diff to assess what has changed in the configure script: