Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oasis: remove tests #8031

Merged
merged 1 commit into from
Dec 7, 2016
Merged

oasis: remove tests #8031

merged 1 commit into from
Dec 7, 2016

Conversation

samoht
Copy link
Member

@samoht samoht commented Dec 7, 2016

They seems broken, /cc @gildor478

The error I get:

#=== ERROR while installing oasis.0.4.8 =======================================#
# opam-version 1.2.2
# os           linux
# command      ocaml setup.ml -configure --enable-tests
# path         /home/travis/.opam/4.03.0/build/oasis.0.4.8
# compiler     4.03.0
# exit-code    1
# env-file     /home/travis/.opam/4.03.0/build/oasis.0.4.8/oasis-4721-ad29c8.env
# stdout-file  /home/travis/.opam/4.03.0/build/oasis.0.4.8/oasis-4721-ad29c8.out
# stderr-file  /home/travis/.opam/4.03.0/build/oasis.0.4.8/oasis-4721-ad29c8.err
### stderr ###
# ocamlfind: Package `expect.pcre' not found
# W: Field 'pkg_expect_pcre' is not set: Command ''/home/travis/.opam/4.03.0/bin/ocamlfind' query -format %d expect.pcre > '/tmp/oasis-402383.txt'' terminated with error code 2
# E: Cannot find findlib package expect.pcre (>= 0.0.4)
# E: Failure("1 configuration error")

@camelus
Copy link
Contributor

camelus commented Dec 7, 2016

✅ All lint checks passed ac84150
  • These packages passed lint tests: oasis.0.4.8

✅ Installability check (5833 → 5833)

@samoht samoht merged commit 72444f0 into ocaml:master Dec 7, 2016
@samoht samoht deleted the oasis-tests branch December 7, 2016 16:07
@gildor478
Copy link
Member

That is because of a flag quickstart_tests which is on by default... Need to find a good solution.

@Chris00
Copy link
Member

Chris00 commented Dec 8, 2016

The latest master of oasis2opam — with the new dependency generator — produces:

depends: [
  "base-unix"
  "camlp4" {test}
  "expect" {test & >= "0.0.4"}
  "fileutils" {test & >= "0.4.2"}
  "ocamlbuild"
  "ocamlfind" {>= "1.3.1"}
  "ocamlify" {build}
  "ocamlmod" {build & test}
  "omake" {test}
  "ounit" {test & >= "2.0.0"}
  "pcre" {test}
]
depopts: [
  "benchmark"
]
conflicts: [
  "benchmark" {< "1.2"}
  "oasis-mirage" {= "0.3.0"}
  "oasis-mirage" {= "0.3.0a"}
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants