Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable again tests on oasis 0.4.8 #8040

Merged
merged 6 commits into from
Jan 6, 2017
Merged

Enable again tests on oasis 0.4.8 #8040

merged 6 commits into from
Jan 6, 2017

Conversation

Chris00
Copy link
Member

@Chris00 Chris00 commented Dec 8, 2016

No description provided.

@camelus
Copy link
Contributor

camelus commented Dec 8, 2016

✅ All lint checks passed 2471025
  • These packages passed lint tests: ANSITerminal.0.6.2, ANSITerminal.0.6.3, ANSITerminal.0.6, oasis.0.4.8

✅ Installability check (5835 → 5835)

@Chris00
Copy link
Member Author

Chris00 commented Dec 8, 2016

@AltGr Doesn't writing build & test means that the dependency is required both for build and also for test (a logical "or" for the predicate)?

@gildor478
Copy link
Member

Please fix the dev-repo, it should be "git://github.com/ocaml/oasis.git#opam/testing"

@Chris00
Copy link
Member Author

Chris00 commented Dec 8, 2016 via email

@gildor478
Copy link
Member

Your question is: why the branch opam/testing is a few version away from master for the repository git://github.com/ocaml/oasis.git ?

If this is your question, the answer is:
The job to promote master (-> opam/unstable) -> opam/testing was not run yesterday and has only been triggered this morning. It is actually still running (it builds all the reverse dependencies of OASIS). If everything is good, it will be promoted in a few hours.

@Chris00
Copy link
Member Author

Chris00 commented Dec 8, 2016

My question was more: if you insist that opam/testing is the right dev-repo for OPAM, why doesn't the _oasis file in the tarball says the same (in the SourceRepository).

@gildor478
Copy link
Member

See oasis2opam#32

@Chris00
Copy link
Member Author

Chris00 commented Dec 9, 2016

@gildor478 The bug report field is declared in opam as

bug-reports: "http://oasis.forge.ocamlcore.org/"

but, given the _oasis one, should be

bug-reports: "https://forge.ocamlcore.org/tracker/?func=add&group_id=54&atid=291"

If you agree, I'll update this PR (the latest oasis2opam uses BugReports when present).

@gildor478
Copy link
Member

Yes, thanks.

@Chris00
Copy link
Member Author

Chris00 commented Dec 25, 2016

Ping?

@gildor478
Copy link
Member

@Chris00 sorry to ask but who are you pinging (me or opam-repository maintainer?)

@avsm
Copy link
Member

avsm commented Jan 3, 2017

Sorry, not had a chance to test this over the holidays. Will do shortly.

@avsm avsm merged commit 292276d into ocaml:master Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants