Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: restrict deps to < 3.0 for findlib package name changes #9156

Merged
merged 1 commit into from
May 18, 2017

Conversation

dsheets
Copy link
Member

@dsheets dsheets commented May 12, 2017

Due to mirage/ocaml-github#192, the findlib package names will be changing.

/cc @AltGr @avsm @samoht

@camelus
Copy link
Contributor

camelus commented May 12, 2017

✅ All lint checks passed 534b552
  • These packages passed lint tests: datakit-bridge-github.0.10.0, datakit-bridge-github.0.10.1, datakit-bridge-github.0.9.0, github-hooks.0.1.1, github-hooks.0.1.2, opam-sync-github-prs.1.1.0, publish.0.3.4

✅ Installability check (6689 → 6689)

@avsm
Copy link
Member

avsm commented May 12, 2017

see moby/datakit#554 for datakit-github-bridge failure on mtime.os

@dsheets dsheets force-pushed the github-3-restrict branch from 4b3798a to 534b552 Compare May 18, 2017 11:16
@dsheets
Copy link
Member Author

dsheets commented May 18, 2017

I've rebased this PR and restarted the CI and the same datakit-bridge-github mtime.os failures keep happening. I'm not sure what else to do or why the CI is still failing.

@samoht
Copy link
Member

samoht commented May 18, 2017

Seems that there is a missing "mtime" {< "1.0.0"} constraint in datakit-github-brige 0.10.1

@samoht
Copy link
Member

samoht commented May 18, 2017

The revdep is fixed by #9221

@samoht samoht merged commit 4d66391 into ocaml:master May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants