Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set MANPATH on any BSD-like (incl. macos) #3325

Merged
merged 3 commits into from
May 2, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGES
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,17 @@ Changes prefixed with "(*)" are potentially breaking to scripts or existing
repositories (changes that are automatically handled by the format upgrade tools
are not marked).

2.0.0~rc2
* Fixes
* Much faster CUDF universe loading
* Much faster `opam env` and similar commands
* Added `opam admin check` for integrity checks on package repositories
* Added the ability to setup scripts on `opam init` from `.opamrc`
* Setup wrappers to sandbox builds based on `bubblewrap` by default, on Linux
* Windows support for many aspects including parallel processes, environment
variables setup, color console and utf8 (using specific C stubs)
* Better detection of the running shell

2.0.0~rc
* Fixes
* Support compiling on OCaml 4.06.0
Expand Down
2 changes: 1 addition & 1 deletion configure.ac
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
AC_INIT(opam,2.0.0~rc)
AC_INIT(opam,2.0.0~rc2)
AC_COPYRIGHT(Copyright 2012-2017 OcamlPro SAS)

AC_CONFIG_MACRO_DIR([m4])
Expand Down
6 changes: 3 additions & 3 deletions doc/pages/Upgrade_guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,9 @@ doesn't affect the pinned package.
- [`opam install --destdir`](man/opam-install.html#lbAF) can be used to copy
build artefacts of given packages to an external prefix

- __sandboxing__ of package build/install/remove commands is enabled by default
on Linux. You may need to install the
[bubblewrap](https://github.com/projectatomic/bubblewrap) tool for this.
- __sandboxing__: on Linux, all package commands will now be sandboxed by
default. The [`bubblewrap`](https://github.com/projectatomic/bubblewrap) tool
is now required to this end.

## File formats

Expand Down
6 changes: 3 additions & 3 deletions opam-client.opam
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
opam-version: "1.2"
version: "2.0.0~rc"
version: "2.0.0~rc2"
maintainer: "opam-devel@lists.ocaml.org"
authors: [
"Thomas Gazagnaire <thomas@gazagnaire.org>"
Expand All @@ -19,8 +19,8 @@ build: [
[make "%{name}%.install"]
]
depends: [
"opam-state" {= "2.0.0~rc"}
"opam-solver" {= "2.0.0~rc"}
"opam-state" {= "2.0.0~rc2"}
"opam-solver" {= "2.0.0~rc2"}
"re" {>= "1.7.2"}
"cmdliner" {>= "0.9.8"}
"jbuilder" {build & >= "1.0+beta18"}
Expand Down
2 changes: 1 addition & 1 deletion opam-core.opam
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
opam-version: "1.2"
version: "2.0.0~rc"
version: "2.0.0~rc2"
maintainer: "opam-devel@lists.ocaml.org"
authors: [
"Thomas Gazagnaire <thomas@gazagnaire.org>"
Expand Down
4 changes: 2 additions & 2 deletions opam-devel.opam
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
opam-version: "1.2"
version: "2.0.0~rc"
version: "2.0.0~rc2"
maintainer: "opam-devel@lists.ocaml.org"
authors: [
"Thomas Gazagnaire <thomas@gazagnaire.org>"
Expand All @@ -20,7 +20,7 @@ build: [
]
build-test: [make "tests"]
depends: [
"opam-client" {= "2.0.0~rc"}
"opam-client" {= "2.0.0~rc2"}
"cmdliner" {>= "0.9.8"}
"jbuilder" {build & >= "1.0+beta18"}
]
Expand Down
6 changes: 3 additions & 3 deletions opam-format.opam
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
opam-version: "1.2"
version: "2.0.0~rc"
version: "2.0.0~rc2"
maintainer: "opam-devel@lists.ocaml.org"
authors: [
"Thomas Gazagnaire <thomas@gazagnaire.org>"
Expand All @@ -19,8 +19,8 @@ build: [
[make "%{name}%.install"]
]
depends: [
"opam-core" {= "2.0.0~rc"}
"opam-file-format" {>= "2.0.0~beta5"}
"opam-core" {= "2.0.0~rc2"}
"opam-file-format" {>= "2.0.0~rc2"}
"jbuilder" {build & >= "1.0+beta18"}
]
available: ocaml-version >= "4.02.3"
4 changes: 2 additions & 2 deletions opam-installer.opam
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
opam-version: "1.2"
version: "2.0.0~rc"
version: "2.0.0~rc2"
maintainer: "opam-devel@lists.ocaml.org"
authors: [
"Thomas Gazagnaire <thomas@gazagnaire.org>"
Expand All @@ -21,7 +21,7 @@ build: [
[make "%{name}%.install"]
]
depends: [
"opam-format" {= "2.0.0~rc"}
"opam-format" {= "2.0.0~rc2"}
"cmdliner" {>= "0.9.8"}
"jbuilder" {build & >= "1.0+beta17"}
]
Expand Down
4 changes: 2 additions & 2 deletions opam-repository.opam
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
opam-version: "1.2"
version: "2.0.0~rc"
version: "2.0.0~rc2"
maintainer: "opam-devel@lists.ocaml.org"
authors: [
"Thomas Gazagnaire <thomas@gazagnaire.org>"
Expand All @@ -19,7 +19,7 @@ build: [
[make "%{name}%.install"]
]
depends: [
"opam-format" {= "2.0.0~rc"}
"opam-format" {= "2.0.0~rc2"}
"jbuilder" {build & >= "1.0+beta17"}
]
available: ocaml-version >= "4.02.3"
4 changes: 2 additions & 2 deletions opam-solver.opam
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
opam-version: "1.2"
version: "2.0.0~rc"
version: "2.0.0~rc2"
maintainer: "opam-devel@lists.ocaml.org"
authors: [
"Thomas Gazagnaire <thomas@gazagnaire.org>"
Expand All @@ -19,7 +19,7 @@ build: [
[make "%{name}%.install"]
]
depends: [
"opam-format" {= "2.0.0~rc"}
"opam-format" {= "2.0.0~rc2"}
"mccs" {>= "1.1+4"}
"dose3" {>= "5"}
"cudf" {>= "0.7"}
Expand Down
4 changes: 2 additions & 2 deletions opam-state.opam
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
opam-version: "1.2"
version: "2.0.0~rc"
version: "2.0.0~rc2"
maintainer: "opam-devel@lists.ocaml.org"
authors: [
"Thomas Gazagnaire <thomas@gazagnaire.org>"
Expand All @@ -19,7 +19,7 @@ build: [
[make "%{name}%.install"]
]
depends: [
"opam-repository" {= "2.0.0~rc"}
"opam-repository" {= "2.0.0~rc2"}
"jbuilder" {build & >= "1.0+beta18"}
]
available: ocaml-version >= "4.02.3"
10 changes: 5 additions & 5 deletions src/client/opamCommands.ml
Original file line number Diff line number Diff line change
Expand Up @@ -1494,11 +1494,11 @@ let repository =
" ", `add, [],
(* using an unbreakable space here will indent the text paragraph at the level
of the previous labelled paragraph, which is what we want for our note. *)
"$(b,Note:) By default, the repository is only be added to the current switch. \
To add a switch to other repositories, you need to use the $(b,--all) or \
$(b,--set-default) options (see below). If you want to enable a repository \
only to install of of its switches, you may be looking for \
$(b,opam switch create --repositories=REPOS).";
"$(b,Note:) By default, the repository is only added to the current \
switch. To add a switch to other repositories, you need to use the \
$(b,--all) or $(b,--set-default) options (see below). If you want to \
enable a repository only to install of of its switches, you may be \
looking for $(b,opam switch create --repositories=REPOS).";
"remove", `remove, ["NAME..."],
"Unselects the given repositories so that they will not be used to get \
package definitions anymore. With $(b,--all), makes opam forget about \
Expand Down
2 changes: 1 addition & 1 deletion src/state/opamEnv.ml
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ let compute_updates ?(force_path=false) st =
let man_path =
let open OpamStd.Sys in
match os () with
| OpenBSD | NetBSD | FreeBSD ->
| OpenBSD | NetBSD | FreeBSD | Darwin | DragonFly ->
[] (* MANPATH is a global override on those, so disabled for now *)
| _ ->
["MANPATH", EqColon,
Expand Down