Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kill builds on Ctrl-C with bubblewrap #4530

Merged
merged 2 commits into from
Feb 15, 2021
Merged

Kill builds on Ctrl-C with bubblewrap #4530

merged 2 commits into from
Feb 15, 2021

Conversation

kit-ty-kate
Copy link
Member

@kit-ty-kate kit-ty-kate commented Feb 7, 2021 •
edited
Loading

Per comment in #4400 (comment), I don't think we need to worry about supporting older version of bubblewrap.

  • Only users on Debian 9 (EOL since July 2020) will have to upgrade bubblewrap
  • Also, turns out opam already required bubblewrap >= 0.1.7

Fixes #4400

@kit-ty-kate kit-ty-kate added this to the 2.1.1 milestone Feb 7, 2021
avsm
avsm approved these changes Feb 8, 2021
View reviewed changes
Copy link
Member

@avsm avsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped version requirement looks good to me.

@rjbou rjbou added the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Feb 10, 2021
@rjbou rjbou modified the milestones: 2.1.1, 2.1.0~beta5 Feb 11, 2021
@rjbou rjbou removed the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Feb 11, 2021
@rjbou rjbou force-pushed the kill-builds-ctrl-c branch from 96e0b9e to 7245c4e Compare February 12, 2021 17:38
@rjbou rjbou merged commit e9ed159 into ocaml:master Feb 15, 2021
@rjbou
Copy link
Collaborator

rjbou commented Feb 15, 2021

Thanks!

@rjbou rjbou mentioned this pull request Mar 10, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avsm avsm avsm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0~rc
Development

Successfully merging this pull request may close these issues.

"Ctrl-C" during installation quits opam but the build continues
3 participants
@kit-ty-kate @rjbou @avsm