depexts: Disable the detection of available packages on RHEL-based distributions #4791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just tried the |
rjbou
reviewed
Aug 23, 2021
rjbou
added
the
PR: QUEUED
|
Good to go for me (with comment), it just need to be updated on github action depext test once finished. |
rjbou
added
PR: NEEDS UPDATE
and removed
PR: QUEUED
|
Thanks! |
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-monorepo
that referenced
this pull request
May 2, 2023
As ocaml/opam#4791 removed support for detection of available packages on Fedora and according to @kit-ty-kate the detection is very dependent on the system, this test is too flaky to be useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4790 shows that
yum listis an unreliable command to use and no options seems to be available to make it so.#4759 also shows that RHEL-based distributions have virtual packages that opam is not taking into account.
For these two reasons I propose we simply remove the use of
yum listin favour ofrpm -qawhich seems way more reliable and leaps faster (~0.1s vs. ~2s!!).Sadly we incidently disable the detection of available packages and thus revert to the behaviour of the opam-depext plugin.
IMO this is not a big deal as only a few distributions that we support actually have it disabled as well due to the method to acquire the data being either incomplete or too tedious/unreliable. This is the case currently (in 2.1.0) for FreeBSD, Gentoo, Homebrew, NetBSD and OpenBSD