Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether the repository might need updating more often #4935

Merged
merged 1 commit into from
Dec 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion master_changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ users)
* Refactored, fixed, improved and optimised the z3 solver backend [#4878 @altgr]

## Client
*
* Check whether the repository might need updating more often [#4935 @kit-ty-kate]

## Internal
* Add license and lowerbounds to opam files [#4714 @kit-ty-kate]
Expand Down
1 change: 0 additions & 1 deletion src/client/opamClient.ml
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ let get_installed_atoms t atoms =
(* Check atoms for pinned packages, and update them. Returns the state that
may have been reloaded if there were changes *)
let update_dev_packages_t ?(only_installed=false) atoms t =
OpamRepositoryState.check_last_update ();
if OpamClientConfig.(!r.skip_dev_update) then t else
let working_dir = OpamClientConfig.(!r.working_dir || !r.inplace_build) in
let to_update =
Expand Down
1 change: 1 addition & 0 deletions src/client/opamSolution.ml
Original file line number Diff line number Diff line change
Expand Up @@ -1279,6 +1279,7 @@ let resolve t action ~orphans ?reinstall ~requested request =
(`A (List.map (fun s -> `String s) (Array.to_list Sys.argv)));
OpamJson.append "switch" (OpamSwitch.to_json t.switch)
);
OpamRepositoryState.check_last_update ();
let universe =
OpamSwitchState.universe t ~requested ?reinstall action
in
Expand Down
1 change: 0 additions & 1 deletion src/client/opamSwitchCommand.ml
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,6 @@ let install_compiler
OpamEnv.check_and_print_env_warning t);
t
end else
let () = OpamRepositoryState.check_last_update () in
let atoms = OpamFormula.atoms invariant in
let names_of_atoms at = OpamPackage.Name.Set.of_list (List.map fst at) in
let comp_roots = names_of_atoms atoms in
Expand Down