Windows: remove double printing on commands and their output #4940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
commented
Dec 1, 2021
| @@ -639,8 +639,8 @@ let exit_status p return = | |||
| if isset_verbose_f () then | |||
| stop_verbose_f () | |||
| else if p.p_verbose then | |||
| (verbose_print_cmd p; | |||
There was a problem hiding this comment.
It is already printed on set_verbose_process call.
| (verbose_print_cmd p; | ||
| List.iter verbose_print_out stdout; | ||
| (List.iter verbose_print_out stdout; | ||
| if p.p_stdout <> p.p_stderr then |
There was a problem hiding this comment.
By default stderr is set to stdout.
rjbou
added a commit
to rjbou/opam
that referenced
this pull request
Aug 8, 2022
Windows: remove double printing on commands and their output
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A specific behavior is set for non windows devices to handle verbose printing of commands and their output. This makes windows workflow go into the fallback one, and have the double printing.