Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cygwin git operation on Windows checkouts #5119

Merged
merged 2 commits into from
Apr 14, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/scripts/cygwin.cmd
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,11 @@ set CYGWIN_PACKAGES=make,patch,curl,diffutils,tar,unzip,git,gcc-g++,libicu-devel
:: up the call to ldd later!
%CYGWIN_ROOT%\bin\bash -lc "uname -a"

:: Mitigations added for CVE-2022-24765 cause error messages as the owner of the
:: git checkout won't be correct. It simply doesn't matter on a CI system, so
:: just add the directory to safe.directory to ignore it.
%CYGWIN_ROOT%\bin\bash -c "git config --global --add safe.directory $PWD"

echo ::endgroup::

:: cygpath %CYGWIN_ROOT% will return / which isn't very helpful. Instead, call
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/ci.ml
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@ on:
- '*.opam'
- 'Makefile*'
- 'configure*'
- '.github/scripts/main/**'
- '.github/scripts/common/**'
- '.github/scripts/**'
- '.github/workflows/main.yml'
- 'tests/**'
# paths-ignore:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ on:
- '*.opam'
- 'Makefile*'
- 'configure*'
- '.github/scripts/main/**'
- '.github/scripts/common/**'
- '.github/scripts/**'
- '.github/workflows/main.yml'
- 'tests/**'
# paths-ignore:
Expand Down
1 change: 1 addition & 0 deletions master_changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ users)
## Infrastructure
* Fix caching of Cygwin compiler on AppVeyor [#4988 @dra27]
* Small update to GHA scripts [#5055 @dra27]
* Adapt Windows CI to new safe.directory setting [#5119 @dra27]

## Admin
* ✘ `opam admin cache` now ignores all already present cache files. Option
Expand Down