Do not update .changes file during dry-run #5144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
na4zagin3
added a commit
to na4zagin3/opam
that referenced
this pull request
May 14, 2022
na4zagin3
added a commit
to na4zagin3/opam
that referenced
this pull request
May 14, 2022
na4zagin3
added a commit
to na4zagin3/opam
that referenced
this pull request
May 14, 2022
rjbou
approved these changes
May 16, 2022
This commit adds a test case to reproduce a bug reported at ocamlgh-5132 where `.changes` files are updated during dry-run.
|
Thank you for updating and merging this! |
Leonidas-from-XIV
pushed a commit
to Leonidas-from-XIV/opam
that referenced
this pull request
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the main bug reported at #5132 by preventing
.changesfiles from being updated during dry-run.This PR also introduces a new trace log to
ACTIONsection to make easy to investigate the issue reported at #4419, which may be the same as the second problem reported at #5132.ToDo:
master_changes.mdfile with your changes.