Various speedups on tasks that do not require availability information (e.g. opam list --installed) #5317
Conversation
kit-ty-kate
added
the
PR: QUEUED
kit-ty-kate
force-pushed
the
speedup-opam-list-installed
branch
from
b5b0d66
to
9b2d813
Compare
kit-ty-kate
removed
the
PR: QUEUED
kit-ty-kate
force-pushed
the
speedup-opam-list-installed
branch
from
9b2d813
to
38c333d
Compare
|
Bench shows a speed up on |
| @@ -1346,7 +1346,7 @@ let dependencies_filter_to_formula_t ~build ~post st nv = | |||
| OpamFilter.filter_formula ~default:true env | |||
|
|
|||
| let dependencies_t st base_deps_compute deps_compute | |||
| ~depopts ~installed ?(unavailable=false) packages = | |||
| ~depopts ~installed ~unavailable packages = | |||
There was a problem hiding this comment.
How this change speeds up dependencies computation?
There was a problem hiding this comment.
it doesn't, but as the dedicated commit says:
Make ?unavailable a non-optional argument to enforce speedups when availability information is not needed
it only enforces that the availability information is used purposefully and ensures that regression won't happen, as the default unavailable=false makes it so that the availability information is used and thus the command will take significantly longer
There was a problem hiding this comment.
Yup, I've read the commit message.
The optional argument unavailable will anyway be used on purpose as when calling the function if we want unavailable packages we need to specify it and usually we don't want it. It won't change ow the function is used to have the argument optional or just labelled. As changes show, all omitted unavailable argument were false, as when we need it, it is already to true.
I'm not convinced, but I won't request a change. It's worth mentioning it in the documentation of the function, that requesting only for available package will add an extra computation time.
There was a problem hiding this comment.
As changes show, all omitted
unavailableargument were false, as when we need it, it is already to true.
I don't think that's an viable argument. We could've changed the behaviour of the commands that use this function if we had known and this holds for future change as well. Also i haven't checked that each commands actually require ~unavailable:false. I simply used its previous default to avoid breaking the current behaviour and also because it's outside of the scope of this PR.
It's worth mentioning it in the documentation of the function, that requesting only for available package will add an extra computation time.
I agree. What do you think of e5277ca ?
kit-ty-kate
force-pushed
the
speedup-opam-list-installed
branch
from
ffab04a
to
69d69ed
Compare
kit-ty-kate
force-pushed
the
speedup-opam-list-installed
branch
2 times, most recently
from
e5277ca
to
df46f93
Compare
…not require availiblity information
…ailablity information is not needed
kit-ty-kate
force-pushed
the
speedup-opam-list-installed
branch
from
df46f93
to
4026447
Compare
Fixes #5314
Queued on #6149