Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of OPAMFETCH (support quotes / proper POSIX shell syntax) #5492

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix parsing of OPAMFETCH (support quotes / proper POSIX shell syntax) #5492

wants to merge 3 commits into from

Conversation

kit-ty-kate
Copy link
Member

Fixes #5490

@kit-ty-kate kit-ty-kate added the PR: WIP Not for merge at this stage label Mar 24, 2023
@kit-ty-kate kit-ty-kate mentioned this pull request Mar 24, 2023
Open
@scjung
Copy link

scjung commented Mar 27, 2023

It works! Thanks for the fix 👍

Processing  1/3: [coreutil.1.70: http]
+ /usr/local/bin/wget "--header" "Authorization: token >>>redacted<<" "https://github.com/>>redacted<</coreutil/archive/refs/tags/v1.70.tar.gz" "-O" "/Users/mukka/.opam/5.0/.opam-switch/sources/coreutil.1.70/v1.70.tar.gz.part"
- --2023-03-27 09:18:43--  https://github.com/>>redacted<</coreutil/archive/refs/tags/v1.70.tar.gz
- Resolving github.com (github.com)... 20.200.245.247
- Connecting to github.com (github.com)|20.200.245.247|:443... connected.
- HTTP request sent, awaiting response... 302 Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: WIP Not for merge at this stage
Projects
None yet
Milestone
2.4.0~alpha1
Development

Successfully merging this pull request may close these issues.

Tokenize OPAMFETCH value properly, not splitting by whitespaces
2 participants
@kit-ty-kate @scjung