Add package stanza on all rules that depend on opamMain.exe.exe
#5496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compilation fails if $ dune build --only-packages opam-core,opam-format,opam-repository As it tries to build the binary, but can't due to the opam package not being compiled. This adds the `package` stanza to the associated rules to avoid the rules being triggered when the `opam` package is not selected.
emillon
added a commit
to ocaml/dune
that referenced
this pull request
Mar 30, 2023
While fixing the package associations in ocaml/opam#5496 I realized that the package stanza is only accepted when it is at the end of the rule stanza. * Add test that `packages` needs to be last, or it will be rejected File "dune", line 12, characters 3-10: 12 | (package a) ^^^^^^^ Error: Unknown action or rule field. [1] Signed-off-by: Marek Kubica <marek@tarides.com> Co-authored-by: Etienne Millon <me@emillon.org>
emillon
added a commit
to emillon/dune
that referenced
this pull request
Mar 31, 2023
While fixing the package associations in ocaml/opam#5496 I realized that the package stanza is only accepted when it is at the end of the rule stanza. * Add test that `packages` needs to be last, or it will be rejected File "dune", line 12, characters 3-10: 12 | (package a) ^^^^^^^ Error: Unknown action or rule field. [1] Signed-off-by: Marek Kubica <marek@tarides.com> Co-authored-by: Etienne Millon <me@emillon.org>
Leonidas-from-XIV
changed the title
package stanza on all packages that depend on opamMain.exe.exepackage stanza on all rules that depend on opamMain.exe.exe
kit-ty-kate
approved these changes
Apr 3, 2023
rjbou
approved these changes
Apr 3, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compilation fails if
As it tries to build the binary, but can't due to the opam package not being compiled. This adds the
packagestanza to the associated rules to avoid the rules being triggered when theopampackage is not selected.