Silently mark packages requiring an unsupported version of opam as unavailable #5665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
force-pushed
the
repo-upgrade-path
branch
2 times, most recently
from
50bbdf2
to
85f6ebe
Compare
rjbou
force-pushed
the
repo-upgrade-path
branch
from
692465f
to
b88b9a4
Compare
dra27
reviewed
Mar 10, 2024
There was a problem hiding this comment.
I think this PR is an excellent idea - it concludes groundwork I laid in ocaml/opam-file-format#44 in opam 2.1.
kit-ty-kate
force-pushed
the
repo-upgrade-path
branch
from
9a675df
to
b7a875f
Compare
rjbou
force-pushed
the
repo-upgrade-path
branch
from
b7a875f
to
82fab22
Compare
rjbou
reviewed
May 3, 2024
|
Updated the PR |
kit-ty-kate
force-pushed
the
repo-upgrade-path
branch
2 times, most recently
from
6fe9a90
to
f34f3b7
Compare
|
rebased |
rjbou
reviewed
Aug 13, 2024
rjbou
force-pushed
the
repo-upgrade-path
branch
from
f34f3b7
to
62d8e8e
Compare
kit-ty-kate
force-pushed
the
repo-upgrade-path
branch
from
62d8e8e
to
da3d901
Compare
rjbou
reviewed
Aug 20, 2024
rjbou
reviewed
Sep 3, 2024
dra27
reviewed
Sep 3, 2024
rjbou
added
the
PR: QUEUED
|
Once rebased on top of 6199, good to go! |
kit-ty-kate
force-pushed
the
repo-upgrade-path
branch
from
73a0cfa
to
60039ce
Compare
kit-ty-kate
removed
the
PR: QUEUED
…sitories containing opam files with an unsupported version
kit-ty-kate
force-pushed
the
repo-upgrade-path
branch
from
60039ce
to
03296d2
Compare
kit-ty-kate
force-pushed
the
repo-upgrade-path
branch
from
03296d2
to
537d216
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5631
This makes it possible to have a smoother upgrade path for the opam repository when opam adds a new syntax for example.
In the future it would be nice to have a specific error message to tell the user why this package is not available, but I feel like we can do this later (TODO: open a ticket for it if this is merged first)