Harden windows_get_shell
#5714
Merged
Harden windows_get_shell
#5714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
approved these changes
Nov 2, 2023
|
related to #5644 (comment) |
rjbou
reviewed
Nov 6, 2023
master_changes.md
Outdated
| @@ -105,6 +105,7 @@ users) | |||
| ## Internal | |||
|
|
|||
| ## Internal: Windows | |||
| * Fix sporadic crash in shell detection (seen in native containers) [#5714 @dra27] | |||
There was a problem hiding this comment.
note for dev: Missing api changelog
In Windows native containers, the Filename.chop_suffix call in windows_get_shell was occasionally failing. OpamStubs.getProcessAncestry can return empty strings. windows_get_shell now explictly handles the empty string case and .exe is now _optionally_ stripped.
The code for reading new processes would fail to NULL-terminate the list if new entries were read and the target was not found.
The current pointer would end up pointing to a freed block if realloc had to move the process list.
|
I pushed two commits fixing errors in the C stub for determining the shell, one of which was heinous (the pointer into the array would end up pointing at the old array following |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Windows native containers, the
Filename.chop_suffixcall inwindows_get_shellwas occasionally failing.OpamStubs.getProcessAncestrycan return empty strings.windows_get_shellnow explictly handles the empty string case and.exeis now optionally stripped.