-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opam env: fix carriage return on Cygwin shell #5715
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
reviewed
Nov 2, 2023
emillon
reviewed
Nov 20, 2023
kit-ty-kate
approved these changes
Nov 21, 2023
kit-ty-kate
reviewed
Nov 28, 2023
rjbou
commented
Nov 28, 2023
rjbou
changed the title
opam env: fix carriage return on Cygwin
opam env: fix carriage return on Cygwin shell
Nov 28, 2023
emillon
reviewed
Nov 28, 2023
rjbou
added
the
PR: QUEUED
Pending pull request, waiting for other work to be merged or closed
label
Nov 28, 2023
dra27
reviewed
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible C simplification
Updated @kit-ty-kate ! |
rjbou
added
PR: WAITING FOR REVIEW
and removed
PR: QUEUED
Pending pull request, waiting for other work to be merged or closed
labels
Dec 11, 2023
kit-ty-kate
reviewed
Dec 19, 2023
todo : Update with cloning file descriptors instead of mutex |
kit-ty-kate
force-pushed
the
env-cr-win
branch
3 times, most recently
from
January 8, 2024 14:07
da86aa3
to
d3877c8
Compare
kit-ty-kate
force-pushed
the
env-cr-win
branch
from
January 8, 2024 14:34
d3877c8
to
430adbb
Compare
kit-ty-kate
force-pushed
the
env-cr-win
branch
from
January 9, 2024 00:51
430adbb
to
e8169ae
Compare
opam env -v includes comments indicating where the packages come from. In sh-compatible outputs, the colon operator is used. This was erroneously used for both cmd and pwsh, neither of which support it.
When the output of opam env is not to a console, the output needs to be literal for shells and not CRLF-translated on Windows.
kit-ty-kate
force-pushed
the
env-cr-win
branch
from
January 11, 2024 00:27
e8169ae
to
8449bad
Compare
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5684