Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows to the release script #5789

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Add windows to the release script #5789

merged 3 commits into from
Jun 20, 2024

Conversation

kit-ty-kate
Copy link
Member

Fixes #5734

@kit-ty-kate kit-ty-kate requested a review from dra27 January 19, 2024 12:46
@kit-ty-kate kit-ty-kate mentioned this pull request Jan 19, 2024
Open
dra27
dra27 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dra27
Copy link
Member

dra27 commented Jan 22, 2024

(modulo squashing, obviously)

@kit-ty-kate kit-ty-kate added this to the 2.2.0~rc1 milestone Jun 11, 2024
kit-ty-kate
kit-ty-kate commented Jun 14, 2024
View reviewed changes
release/readme.md Outdated Show resolved Hide resolved
@kit-ty-kate
Copy link
Member Author

kit-ty-kate commented Jun 18, 2024 •
edited
Loading

What's missing:

  • make sure -machine q35 fixes the crashes (I'm running a full run atm, so i'll have the answer to that in a couple hours) EDIT: looks like it worked.
  • fix ssh (by either finding some easy way to copy or have a known key, or fix the bug that makes sshd need a restart to accept empty passwords half the time)
  • (optional) find a way to disable Windows Defender for the added performance (i've tried everything, nothing worked reliably and on the long term)

@kit-ty-kate kit-ty-kate marked this pull request as ready for review June 18, 2024 16:44
@kit-ty-kate kit-ty-kate merged commit 1d289f1 into ocaml:master Jun 20, 2024
29 checks passed
@kit-ty-kate kit-ty-kate deleted the win-release branch June 20, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dra27 dra27 dra27 approved these changes

Assignees
No one assigned
Labels
AREA: PORTABILITY
Projects
None yet
Milestone
2.2.0~rc1
Development

Successfully merging this pull request may close these issues.

Release: Create a pre-built binary for Windows automatically
3 participants
@kit-ty-kate @dra27 @rjbou