Speedup OpamSystem.read by 8% #5896
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
force-pushed
the
speedup-read
branch
from
fb39b66 to
0585799
Compare
This was referenced Mar 27, 2024
kit-ty-kate
force-pushed
the
speedup-read
branch
3 times, most recently
from
d6e5a37 to
5774d1c
Compare
kit-ty-kate
force-pushed
the
speedup-read
branch
from
5774d1c to
e5dac9f
Compare
|
Local test using the test added in #5900 vs.
|
kit-ty-kate
force-pushed
the
speedup-read
branch
2 times, most recently
from
69841b7 to
22321df
Compare
|
Mmh, the benchmark shows an increase of the time taken for some reason now... :/ I'm converting this PR to draft while we're figuring this out |
kit-ty-kate
force-pushed
the
speedup-read
branch
from
22321df to
4e80cdf
Compare
kit-ty-kate
force-pushed
the
speedup-read
branch
from
4e80cdf to
ff1c7ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while working on #5892
In this particular case, this reduced all of the performance degradation of this version of diff.
I'm opening this PR separately hoping that our benchmark system is heavy enough in reads to show the difference.
Requires #5900 to be merged first