Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the vendored OCaml compiler to 4.14.2 #5976

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Upgrade the vendored OCaml compiler to 4.14.2 #5976

merged 1 commit into from
Jun 4, 2024

Conversation

kit-ty-kate
Copy link
Member

@kit-ty-kate kit-ty-kate commented May 27, 2024 •
edited
Loading

Partially f.i.x.e.s #5956

@kit-ty-kate kit-ty-kate added this to the 2.2.0~beta3 milestone May 27, 2024
@kit-ty-kate kit-ty-kate requested a review from rjbou May 27, 2024 21:06
dra27
dra27 approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

rjbou
rjbou approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dbuenzli
Copy link
Contributor

dbuenzli commented Jun 4, 2024

Does that change lower bound on OCaml to compile opam ? (Mainly interested to inform a corresponding reasonable cmdliner lower bound).

@rjbou
Copy link
Collaborator

rjbou commented Jun 4, 2024

No, it's only the vendored one, used for make cold. Opam keeps ocaml lower bound >= 4.08.0.

@kit-ty-kate kit-ty-kate merged commit 6cf6ff3 into ocaml:master Jun 4, 2024
39 checks passed
@kit-ty-kate kit-ty-kate deleted the vendor-4.14.2 branch June 4, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjbou rjbou rjbou approved these changes

@dra27 dra27 dra27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0~beta3
Development

Successfully merging this pull request may close these issues.
4 participants
@kit-ty-kate @dbuenzli @rjbou @dra27