Fix lint W59 with a local path that is not an archive #6219
+60
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
changed the title
kit-ty-kate
requested changes
Oct 1, 2024
| ### <add-url.sh> | ||
| basedir=$(echo $BASEDIR | sed "s/\\\\\\\\/\\\\\\\\\\\\\\\\/g") | ||
| cat << EOF >> lint.opam | ||
| url { src:"file://$basedir/an-archive" } |
There was a problem hiding this comment.
I'm not sure to understand the issue. The an-archive directory doesn't exists at this point right? Shouldn't we raise a warning here for this?
| let url_archive = | ||
| let open OpamStd.Option.Op in | ||
| t.url >>| OpamFile.URL.url >>| (fun u -> | ||
| OpamSystem.is_archive u.OpamUrl.path) |
There was a problem hiding this comment.
i don't think that's right. is_archive will look up the file locally. If you have an url like https:///etc/fstab, the path will be looked up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6218