Fix lint W59 with a local path that is not an archive #6219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
changed the title
kit-ty-kate
requested changes
Oct 1, 2024
kit-ty-kate
reviewed
Oct 11, 2024
tests/reftests/lint.test
Outdated
| dev-repo: "hg+https://to@li.nt" | ||
| bug-reports: "https://nobug" | ||
| ### <add-url.sh> | ||
| basedir=`echo "$BASEDIR" | sed 's/\\\\/\\\\\\\\\\\\\\\\/g'` |
There was a problem hiding this comment.
you used single quotes here instead of double-quotes and only halved the left part of the sed, not the right part.
Suggested change
| basedir=`echo "$BASEDIR" | sed 's/\\\\/\\\\\\\\\\\\\\\\/g'` | |
| basedir=`echo "$BASEDIR" | sed 's/\\\\/\\\\\\\\/g'` |
There was a problem hiding this comment.
actually what is the goal of this sed? Is it just to escape every backslashes? If so, then the solution might be instead:
Suggested change
| basedir=`echo "$BASEDIR" | sed 's/\\\\/\\\\\\\\\\\\\\\\/g'` | |
| basedir=`echo "$BASEDIR" | sed 's/\\/\\\\/g'` |
I know is everywhere in the reftests in its double-quoted form but i’ve never really understood it ^^"
There was a problem hiding this comment.
It's the different levels of escape that are needed to end with s/\\/\\\\/g launched.
tests/reftests/lint.test
Outdated
| dev-repo: "hg+https://to@li.nt" | ||
| bug-reports: "https://nobug" | ||
| ### <add-url.sh> | ||
| basedir=`echo "$BASEDIR" | sed 's/\\\\/\\\\\\\\\\\\\\\\/g'` |
There was a problem hiding this comment.
same here
Suggested change
| basedir=`echo "$BASEDIR" | sed 's/\\\\/\\\\\\\\\\\\\\\\/g'` | |
| basedir=`echo "$BASEDIR" | sed 's/\\\\/\\\\\\\\/g'` |
…ising the extension
kit-ty-kate
approved these changes
Oct 14, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6218
backported to 2.3 in #6220