Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore .gitattributes #116

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Restore .gitattributes #116

merged 1 commit into from
Jun 15, 2021

Conversation

dra27
Copy link
Member

@dra27 dra27 commented Jun 15, 2021

We accidentally lost the .gitattributes in #66!

@dra27
Copy link
Member Author

dra27 commented Jun 15, 2021

View the diff with https://github.com/ocaml/setup-ocaml/pull/116/files?diff=unified&w=1 (i.e. with whitespace changes ignored!)

@smorimoto
Copy link
Member

I used to mark dist files as linguist-generated because I didn't want the JavaScript to be presented to the GitHub languages list, but now it's no longer required. So I'm not sure if this is really needed.

@dra27
Copy link
Member Author

dra27 commented Jun 15, 2021

It also causes GitHub to display the "Some generated files are not rendered by default." message for the files in dist/ which is extremely useful when reviewing PRs.

The * text=auto is also necessary to ensure the repository files stay normalized.

@dra27 dra27 force-pushed the gitattributes branch 2 times, most recently from d584602 to 614e062 Compare June 15, 2021 12:42
@smorimoto
Copy link
Member

Makes perfect sense 🙏

@smorimoto smorimoto merged commit 796ca5b into ocaml:master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants