Don't make heavy API requests multiple times #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sora Morimoto <sora@morimoto.io>
There was a problem hiding this comment.
PR Overview
This PR aims to avoid making heavy API requests multiple times by caching results at module load time. The key changes are:
- Replacing function calls with immediately invoked async functions for fetching the OCaml compiler version, Cygwin version, and the latest opam release.
- Removing redundant exports and updating references across multiple modules.
- Ensuring consistency in how heavy API requests are handled across the codebase.
Reviewed Changes
| File | Description |
|---|---|
| packages/setup-ocaml/src/version.ts | Changed to cache the resolved compiler using an async IIFE. |
| packages/setup-ocaml/src/windows.ts | Updated to cache the Cygwin version using an async IIFE. |
| packages/setup-ocaml/src/constants.ts | Removed the old RESOLVED_COMPILER export and refined OCAML_COMPILER input. |
| packages/setup-ocaml/src/cache.ts | Updated to use the new cached compiler and Cygwin version values. |
| packages/setup-ocaml/src/installer.ts | Replaced RESOLVED_COMPILER usage with resolvedCompiler from version.ts. |
| packages/setup-ocaml/src/opam.ts | Replaced the function call with an async IIFE for latest opam release retrieval. |
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #943