Keep the build directory clean with the --local-package-dir argument
#949
+13
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up the build directory by leveraging the --local-package-dir argument in the Cygwin setup. Key changes include:
- Removal of the git ignore configuration logic in the Windows setup script.
- Introduction of a new constant, CYGWIN_LOCAL_PACKAGE_DIR, in the constants file.
- Updates to the caching mechanism in cache.ts to remove dependencies on the removed variable.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/setup-ocaml/src/windows.ts | Removed Git configuration for excluding local packages and added the --local-package-dir argument. |
| packages/setup-ocaml/src/constants.ts | Removed CYGWIN_MIRROR_ENCODED_URI and added CYGWIN_LOCAL_PACKAGE_DIR. |
| packages/setup-ocaml/src/cache.ts | Updated cache key composition and directory paths to reflect the removal of CYGWIN_MIRROR_ENCODED_URI. |
Signed-off-by: Sora Morimoto <sora@morimoto.io>
smorimoto
force-pushed
the
local-package-dir
branch
from
4bb2620 to
5480d9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.