Fix package installation logic for the self-hosted runner environment #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sora Morimoto <sora@morimoto.io>
There was a problem hiding this comment.
Pull Request Overview
This PR refines the package installation logic by introducing distinct behavior for self-hosted and GitHub-hosted runners. Key changes include:
- Adding a new constant (RUNNER_ENVIRONMENT) in constants.ts to differentiate between runner types.
- Updating unix.ts to use RUNNER_ENVIRONMENT for conditional package installation and package index updates.
- Refactoring conditional logic by replacing the old process.env.GITHUB_ACTIONS checks with the new runner environment checks.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/setup-ocaml/src/constants.ts | Introduces RUNNER_ENVIRONMENT to support self-hosted and GitHub-hosted runner logic. |
| packages/setup-ocaml/src/unix.ts | Refactors installation and update functions to execute based on the new runner environment. |
Signed-off-by: Sora Morimoto <sora@morimoto.io>
smorimoto
force-pushed
the
fix-install-logic-self-hosted
branch
from
a32f872 to
60cd58a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #940 (comment)