Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Eliom file extensions #487

Merged
merged 2 commits into from
Dec 23, 2020
Merged

Support Eliom file extensions #487

merged 2 commits into from
Dec 23, 2020

Conversation

tmattio
Copy link
Collaborator

@tmattio tmattio commented Dec 23, 2020

No description provided.

@tmattio tmattio requested a review from mnxn December 23, 2020 09:56
@tmattio tmattio mentioned this pull request Dec 23, 2020
Merged
jrochel pushed a commit to jrochel/ocaml-lsp that referenced this pull request Dec 23, 2020
support eliom file extensions
9e0e269 
This will work correctly once the following PR has been merged:
ocamllabs/vscode-ocaml-platform#487
mnxn
mnxn approved these changes Dec 23, 2020
View reviewed changes
Copy link
Collaborator

@mnxn mnxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a change log entry.

Should probably be mentioned in the README's features section.

@tmattio tmattio merged commit efdebc7 into ocamllabs:master Dec 23, 2020
@tmattio tmattio deleted the eliom-file-ext branch December 28, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnxn mnxn mnxn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmattio @mnxn