upgrade ppxlib to 0.26.0 #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI passes; should be ready for a review I plan to remove upper bounds in the next PRs in which I upgrade jsoo |
rgrinberg
approved these changes
Apr 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.26.0 has breaking API changes, so we set the required version of Ppxlib to >= 0.26.0
fix CI failures: upper bound ocaml compiler and dune version
--prettyflag being passed tojs_of_ocaml linkbecause we have(lang dune 2.7)(dune doesn't complain on lang 3.0 about--pretty); see dune passes jsoo compile flags as link flags ocaml/dune#5563(this PR is a result of PR #919 being split in several)