Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace native-tls with rustls #12

Closed
2 tasks done
jiacai2050 opened this issue Mar 6, 2023 · 2 comments · Fixed by #18
Closed
2 tasks done

Replace native-tls with rustls #12

jiacai2050 opened this issue Mar 6, 2023 · 2 comments · Fixed by #18
Assignees
@dust1
Labels
enhancement New feature or request

Comments

@jiacai2050
Copy link
Contributor

jiacai2050 commented Mar 6, 2023 •
edited
Loading

Check Before Asking

  • Please check the issue list and confirm this feature is encountered for the first time.
  • Please try full text in English and attach precise description.

Description

Follow-up request of apache/horaedb#662.

Simply put, I don't want CeresDB to depend on openssl, so I suggest replace it with https://github.com/rustls/rustls

There is only one dependency in this crates which depends on openssl: reqwest, it has rustls support already, we just need to enable it.

Other Information

Similar changes: NoXF/oss-rust-sdk#17
@jiacai2050 jiacai2050 added the enhancement New feature or request label Mar 6, 2023
@jiacai2050 jiacai2050 mentioned this issue Mar 6, 2023
Closed
@ShiKaiWi ShiKaiWi mentioned this issue Mar 7, 2023
Merged
@dust1
Copy link
Contributor

dust1 commented Mar 7, 2023

assigne me

@ShiKaiWi
Copy link
Contributor

ShiKaiWi commented Mar 7, 2023

assigne me

I have such a permission to assign task. @IHEII @chunshao90 Could you assign this task to @dust1?

@dust1 dust1 mentioned this issue Mar 7, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dust1 dust1

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

edit: make native-tls optional dust1/obkv-table-client-rs
3 participants
@jiacai2050 @ShiKaiWi @dust1