-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace native-tls with rustls #701
Conversation
@jiacai2050 I tried to modify the |
Actually, oceanbase/obkv-table-client-rs#12 has been filed. It will be appreciated if you are willing to address that issue. |
I have a problem.after I modified
and change to rustls:
But when I changed rev in ceresdb‘s
do I need to add [features] in obkv-table-rs? |
Isn't this expected? your PR remove native-tls.
No need. Could you try |
yes, i try do it. But obkv-table-client-rs still relies on native tls.😰 |
I will pull your branch to check in my local dev. |
I remove native-tls from oss-rust-sdk, then native-tls is completely gone in CeresDB. 🚀 cargo tree -i -p native-tls
error: package ID specification `native-tls` did not match any packages Merge when CI pass. Thanks for your contribution. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It seems that I was so focused on this problem that I didn't eliminate the others first. thank you😃 |
* edit: try to open rustls in meta_client/request * edit * edit: remove reqwest dep in meta_client * bump oss-sdk, remove native-tls --------- Co-authored-by: jiacai2050 <dev@liujiacai.net>
Which issue does this PR close?
Closes #662
Rationale for this change
Replace native-tls with rustls
What changes are included in this PR?
edit Cargo.toml
Are there any user-facing changes?
none
How does this change test
none