Skip to content

Commit

Permalink
fix(dlm): create connection failed in oracle (#3355)
Browse files Browse the repository at this point in the history
* fix username in oracle.

* fix username in oracle.
  • Loading branch information
guowl3 committed Sep 12, 2024
1 parent f801c5c commit 40f6b13
Showing 1 changed file with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import com.oceanbase.odc.core.shared.constant.ConnectType;
import com.oceanbase.odc.core.shared.exception.UnsupportedException;
import com.oceanbase.odc.plugin.connect.model.JdbcUrlProperty;
import com.oceanbase.odc.plugin.connect.model.oracle.UserRole;
import com.oceanbase.odc.service.connection.model.ConnectionConfig;
import com.oceanbase.odc.service.plugin.ConnectionPluginUtil;
import com.oceanbase.odc.service.session.factory.OBConsoleDataSourceFactory;
Expand Down Expand Up @@ -114,7 +115,7 @@ public static DataSourceInfo toDataSourceInfo(ConnectionConfig connectionConfig,
case ORACLE:
dataSourceInfo.setJdbcUrl(getJdbcUrl(connectionConfig));
dataSourceInfo.setDatabaseType(DataBaseType.ORACLE);
dataSourceInfo.setFullUserName(connectionConfig.getUsername());
dataSourceInfo.setFullUserName(getOracleUsername(connectionConfig));
break;
default:
log.warn(String.format("Unsupported datasource type:%s", connectionConfig.getDialectType()));
Expand All @@ -132,4 +133,9 @@ private static String getJdbcUrl(ConnectionConfig connectionConfig) {
return ConnectionPluginUtil.getConnectionExtension(connectionConfig.getDialectType())
.generateJdbcUrl(jdbcUrlProperty);
}

private static String getOracleUsername(ConnectionConfig connectionConfig) {
return connectionConfig.getUserRole() == UserRole.SYSDBA ? connectionConfig.getUsername() + " as sysdba"
: connectionConfig.getUsername();
}
}

0 comments on commit 40f6b13

Please sign in to comment.