Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix create oracle table failed with quote wrapped by special character #101

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

krihy
Copy link
Collaborator

@krihy krihy commented Aug 31, 2023

What type of PR is this?

module-oneline schema change

What this PR does / why we need it:

1.Create table failed when table contains chinese charcter wrapped by quote

Which issue(s) this PR fixes:

1.Create new table with origin wrapped character
2.Drop new table created by task when task is failed
3.fix checkTaskCronExpression which is not initlized

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@krihy krihy added type-bug Something isn't working priority-high module-Online schema change Online schema change labels Aug 31, 2023
@krihy krihy added this to the ODC 4.2.1 milestone Aug 31, 2023
@krihy krihy self-assigned this Aug 31, 2023
Copy link
Collaborator

@PeachThinking PeachThinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krihy krihy merged commit a5816ad into oceanbase:dev/4.2.1 Aug 31, 2023
5 checks passed
@krihy krihy deleted the yaobin_osc_fix_oracle_table branch September 2, 2023 03:26
yhilmare pushed a commit that referenced this pull request Jan 15, 2024
#101)

* 1.fix oracle table name wrapped by quote

* fix npe by get origin table

* drop new table when start task failed

* checkTaskCronExpression has not initlized
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module-Online schema change Online schema change priority-high type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants