Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql-check): fix can not detect table&column comment when execute a sqlscript #113

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

yhilmare
Copy link
Contributor

@yhilmare yhilmare commented Sep 1, 2023

What type of PR is this?

type-bug

What this PR does / why we need it:

this pr fix a bug, and you can get more details in related.

Which issue(s) this PR fixes:

Fixes #108

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@yhilmare yhilmare added type-bug Something isn't working module-sql execution labels Sep 1, 2023
@yhilmare yhilmare added this to the ODC 4.2.1 milestone Sep 1, 2023
@yhilmare yhilmare self-assigned this Sep 1, 2023
@yhilmare yhilmare changed the base branch from main to dev/4.2.1 September 1, 2023 06:34
Copy link
Contributor

@smallsheeeep smallsheeeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhilmare yhilmare merged commit e693470 into dev/4.2.1 Sep 1, 2023
5 checks passed
@yhilmare yhilmare deleted the fix/shanlu_sql_check branch September 1, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module-sql execution type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: sql check gives an error result on table&column comment when execute a sql
2 participants