Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mysql): sql execution adaption for mysql5.7 #115

Merged

Conversation

PeachThinking
Copy link
Collaborator

What type of PR is this?

type-feature
module-sql execution

What this PR does / why we need it:

  1. Different data sources uniformly use DB_SERVER_EXECUTE_SQL as DB time-consuming, delete OBSERVER_EXECUTE_SQL
  2. fix native mysql show DB execution time unit conversion error

Which issue(s) this PR fixes:

Fixes #2

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@PeachThinking PeachThinking added this to the ODC 4.2.2 milestone Sep 1, 2023
@PeachThinking PeachThinking self-assigned this Sep 1, 2023
@PeachThinking PeachThinking changed the base branch from main to dev/4.2.x September 1, 2023 07:08
Copy link
Collaborator

@LuckyPickleZZ LuckyPickleZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PeachThinking PeachThinking merged commit c36b873 into dev/4.2.x Sep 1, 2023
6 checks passed
@PeachThinking PeachThinking modified the milestones: ODC 4.2.3, ODC 4.2.2 Nov 14, 2023
yhilmare pushed a commit that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module-sql execution priority-high type-feature The functionality to be implemented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Feature]: ODC supports MySQL data source
2 participants