Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(osc): fix sql of alter replace table name not correct #130

Merged
merged 5 commits into from
Sep 4, 2023
Merged

fix(osc): fix sql of alter replace table name not correct #130

merged 5 commits into from
Sep 4, 2023

Conversation

krihy
Copy link
Collaborator

@krihy krihy commented Sep 4, 2023

What type of PR is this?

type-debug
type-online schema change

What this PR does / why we need it:

fix alter type execute failed

Which issue(s) this PR fixes:

  1. oracle new table name with suffix with "OSC_NEW_" and renamed table suffix with "OSC_OLD_"
  2. fix alter type sql replaced by new table name
  3. fix oracle constraints name with uuid, old renamed style may overrun 128 characters

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:

@krihy krihy added type-bug Something isn't working priority-high module-Online schema change Online schema change type-refactor refactor code or rename variables labels Sep 4, 2023
@krihy krihy added this to the ODC 4.2.1 milestone Sep 4, 2023
@krihy krihy self-assigned this Sep 4, 2023
PeachThinking
PeachThinking approved these changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@PeachThinking PeachThinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krihy krihy merged commit 66bb388 into oceanbase:dev/4.2.1 Sep 4, 2023
6 checks passed
@krihy krihy deleted the yaobin_fix_alter_type_create_ddl_failed branch September 4, 2023 08:37
yhilmare pushed a commit that referenced this pull request Jan 15, 2024
@krihy
fix(osc): fix sql of alter replace table name not correct (#130)
d206df9 
* fix alter type generate create ddl

* fix create table ddl

* fix new oracle table upper case

* 1. fix new oracle constraint name too lang

* 1.constraint suffix with char A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeachThinking PeachThinking PeachThinking approved these changes

@yhilmare yhilmare Awaiting requested review from yhilmare

@yizhouxw yizhouxw Awaiting requested review from yizhouxw

@smallsheeeep smallsheeeep Awaiting requested review from smallsheeeep

Assignees

@krihy krihy

Labels
module-Online schema change Online schema change priority-high type-bug Something isn't working type-refactor refactor code or rename variables
Projects
ODC
Archived in project
Milestone
ODC 4.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@krihy @PeachThinking