[WIP]feat(structure-comparison):implemention for OdcDBStructureComparator #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeachThinking
requested review from
yhilmare,
LuckyPickleZZ,
MarkPotato777 and
yizhouxw
PeachThinking
changed the title
PeachThinking
force-pushed
the
feat/jingtian_424_support_schema_structure_sync
branch
from
754c6a1
to
078b5b4
Compare
PeachThinking
changed the title
PeachThinking
force-pushed
the
feat/jingtian_424_support_schema_structure_sync
branch
from
33a7dde
to
1faab7a
Compare
PeachThinking
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-feature
module-structure-comparison
What this PR does / why we need it:
OdcDBStructureComparator：ImplementDBStructureComparatorinterface based ondb-browser.If we can call DBCat SDK in the future, we only need to write another DBCat DBStructureComparator interface implementation class, and the service layer does not need to be aware of it.
The table's columns, indexes, constraints, and partition object's comparison results will be sub-objects of the table DBObjectComparisonResult，refer to
DBObjectComparisonResult#getSubDBObjectComparisonResult().For table object,
DBObjectComparisonResult#getChangeScript()only only record the change script of table options.Add support alter table charset and collate code in
MySQLTableEditor#generateUpdateTableOptionDDL. Oracle do not support alter table charset and collate.Which issue(s) this PR fixes:
Fixes #816
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: