Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integration): external approval is always created when initiating a ticket #140

Merged
merged 6 commits into from
Sep 5, 2023

Conversation

smallsheeeep
Copy link
Contributor

What this PR does / why we need it:

Fix bug: A new instance of external approval is always created when a ticket is initiated

Which issue(s) this PR fixes:

Fixes #67
Close #67

Special notes for your reviewer:

Already passed testing in BPMS.

Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smallsheeeep smallsheeeep merged commit 63409c3 into dev/4.2.1 Sep 5, 2023
5 checks passed
@smallsheeeep smallsheeeep deleted the bugfix/gaoda_421_fix_external_approval branch September 5, 2023 03:28
yhilmare pushed a commit that referenced this pull request Jan 15, 2024
… a ticket (#140)

* fix: external approval

* response to CR

* refine

* response to CR

* fix: cancel external approval

* test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: A new instance of external approval is always created when a ticket is initiated
2 participants