-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data-transfer): upgrade ob-loader-dumper to 4.2.8-RELEASE #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuckyPickleZZ
added
type-feature
The functionality to be implemented
module-Data generation and migration
Mock data,Import,Export
labels
Jan 22, 2024
LuckyPickleZZ
changed the title
feat(data-transfer): upgrade ob-loader-dumper to 2.4.8-RELEASE
feat(data-transfer): upgrade ob-loader-dumper to 4.2.8-RELEASE
Jan 22, 2024
...in/java/com/oceanbase/odc/plugin/task/obmysql/datatransfer/factory/DumpParameterFactory.java
Show resolved
Hide resolved
smallsheeeep
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
module-Data generation and migration
Mock data,Import,Export
type-feature
The functionality to be implemented
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade ob-loader-dumper to 2.4.8-RELEASE. There are two main changes:
They removed
ControlManager#register
method, but will restore it in 2.4.8.1. So we will temporarily delete the call to this method and add it back later.This has resulted in data-mask being temporarily unavailable.
Ob-loader-dumper uses
session.config.json
file to init session, we added it intoserver/plugins/task-plugin-ob-mysql/src/main/resources/session.config.json