Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollbackPlan): fix desktop odc cannot generate rollback plan #145

Conversation

PeachThinking
Copy link
Collaborator

What type of PR is this?

type-bug
modul-Online schema change

What this PR does / why we need it:

desktop odc use flowInstanceService#createIndividualFlowInstance to build flow configure which is different from web odc, and this leads to desktop odc cannot generate rollback plan.

Which issue(s) this PR fixes:

Fixes #127

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@PeachThinking PeachThinking added type-bug Something isn't working priority-medium module-Online schema change Online schema change labels Sep 5, 2023
@PeachThinking PeachThinking added this to the ODC 4.2.1 milestone Sep 5, 2023
@PeachThinking PeachThinking self-assigned this Sep 5, 2023
Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PeachThinking PeachThinking merged commit db9672f into dev/4.2.1 Sep 5, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module-Online schema change Online schema change priority-medium type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants