Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database-permission): failed to verify database permission in personal space #1458

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

smallsheeeep
Copy link
Contributor

What type of PR is this?

type-bug
module-database permission control

What this PR does / why we need it:

In perosnal space, user has all permission for all databases but there is no permission records in metaDB. So the DB permission will failed and user cannot create session. This PR fix it by skipping permission check in personal space.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@smallsheeeep smallsheeeep added this to the ODC 4.2.4 milestone Jan 26, 2024
@smallsheeeep smallsheeeep self-assigned this Jan 26, 2024
@smallsheeeep smallsheeeep changed the base branch from main to dev/4.2.x January 26, 2024 06:55
@smallsheeeep smallsheeeep linked an issue Jan 26, 2024 that may be closed by this pull request
Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit ed51860 into dev/4.2.x Jan 26, 2024
11 checks passed
@yhilmare yhilmare deleted the bugfix/gaoda_42x_fix_db_permission_authorize branch January 26, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Failed to create database session in personal space
2 participants