-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(structure-comparison): integrate structural comparison into the service layer #1473
Merged
yhilmare
merged 24 commits into
dev/4.2.x
from
feat/jingtian_424_structure_compare_access_to_flowable_layer
Feb 7, 2024
Merged
feat(structure-comparison): integrate structural comparison into the service layer #1473
yhilmare
merged 24 commits into
dev/4.2.x
from
feat/jingtian_424_structure_compare_access_to_flowable_layer
Feb 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeachThinking
requested review from
yhilmare,
LuckyPickleZZ,
MarkPotato777 and
yizhouxw
January 29, 2024 09:04
PeachThinking
force-pushed
the
feat/jingtian_424_structure_compare_access_to_flowable_layer
branch
from
January 29, 2024 10:47
e799a60
to
3e74835
Compare
PeachThinking
changed the title
feat(structure-comparison) : access to flowable layer
[WIP]feat(structure-comparison) : access to flowable layer
Jan 30, 2024
pr naming suggestion: integrate structural comparison into the service layer |
PeachThinking
force-pushed
the
feat/jingtian_424_structure_compare_access_to_flowable_layer
branch
from
January 30, 2024 12:49
b18a41e
to
2c859f9
Compare
PeachThinking
changed the title
[WIP]feat(structure-comparison) : access to flowable layer
[WIP]feat(structure-comparison) : integrate structural comparison into the service layer
Jan 30, 2024
PeachThinking
changed the title
[WIP]feat(structure-comparison) : integrate structural comparison into the service layer
feat(structure-comparison) : integrate structural comparison into the service layer
Jan 30, 2024
yhilmare
changed the title
feat(structure-comparison) : integrate structural comparison into the service layer
feat(structure-comparison): integrate structural comparison into the service layer
Jan 31, 2024
...ice/src/main/java/com/oceanbase/odc/service/flow/task/DBStructureComparisonFlowableTask.java
Outdated
Show resolved
Hide resolved
...ice/src/main/java/com/oceanbase/odc/service/flow/task/DBStructureComparisonFlowableTask.java
Outdated
Show resolved
Hide resolved
...ice/src/main/java/com/oceanbase/odc/service/flow/task/DBStructureComparisonFlowableTask.java
Outdated
Show resolved
Hide resolved
...ervice/src/main/java/com/oceanbase/odc/service/structurecompare/StructureComparisonTask.java
Outdated
Show resolved
Hide resolved
...ervice/src/main/java/com/oceanbase/odc/service/structurecompare/StructureComparisonTask.java
Outdated
Show resolved
Hide resolved
…ess_to_flowable_layer
…ess_to_flowable_layer
yhilmare
reviewed
Feb 5, 2024
libs/db-browser/src/main/java/com/oceanbase/tools/dbbrowser/schema/DBSchemaAccessor.java
Outdated
Show resolved
Hide resolved
libs/db-browser/src/main/java/com/oceanbase/tools/dbbrowser/schema/DBSchemaAccessor.java
Outdated
Show resolved
Hide resolved
server/odc-migrate/src/main/resources/migrate/common/V_4_2_4_8__structure_comparison_task.sql
Outdated
Show resolved
Hide resolved
PeachThinking
force-pushed
the
feat/jingtian_424_structure_compare_access_to_flowable_layer
branch
from
February 5, 2024 12:11
331219e
to
a8f4128
Compare
PeachThinking
force-pushed
the
feat/jingtian_424_structure_compare_access_to_flowable_layer
branch
from
February 6, 2024 02:29
24e8c53
to
6ab5a40
Compare
yhilmare
reviewed
Feb 6, 2024
server/odc-migrate/src/main/resources/migrate/common/V_4_2_4_10__structure_comparison_task.sql
Outdated
Show resolved
Hide resolved
server/odc-migrate/src/main/resources/migrate/common/V_4_2_4_10__structure_comparison_task.sql
Outdated
Show resolved
Hide resolved
server/odc-migrate/src/main/resources/migrate/common/V_4_2_4_10__structure_comparison_task.sql
Outdated
Show resolved
Hide resolved
server/odc-migrate/src/main/resources/migrate/common/V_4_2_4_10__structure_comparison_task.sql
Outdated
Show resolved
Hide resolved
.../src/main/java/com/oceanbase/odc/metadb/structurecompare/StructureComparisonEntitySpecs.java
Show resolved
Hide resolved
...ervice/src/main/java/com/oceanbase/odc/service/structurecompare/StructureComparisonTask.java
Outdated
Show resolved
Hide resolved
...ervice/src/main/java/com/oceanbase/odc/service/structurecompare/StructureComparisonTask.java
Outdated
Show resolved
Hide resolved
...ice/src/main/java/com/oceanbase/odc/service/flow/task/DBStructureComparisonFlowableTask.java
Outdated
Show resolved
Hide resolved
...ice/src/main/java/com/oceanbase/odc/service/structurecompare/StructureComparisonService.java
Outdated
Show resolved
Hide resolved
...ice/src/main/java/com/oceanbase/odc/service/structurecompare/StructureComparisonService.java
Outdated
Show resolved
Hide resolved
PeachThinking
force-pushed
the
feat/jingtian_424_structure_compare_access_to_flowable_layer
branch
from
February 7, 2024 01:55
7fb5a29
to
d3cebef
Compare
yhilmare
reviewed
Feb 7, 2024
server/odc-migrate/src/main/resources/migrate/common/V_4_2_4_10__structure_comparison_task.sql
Outdated
Show resolved
Hide resolved
...ervice/src/main/java/com/oceanbase/odc/service/structurecompare/StructureComparisonTask.java
Outdated
Show resolved
Hide resolved
yhilmare
reviewed
Feb 7, 2024
server/odc-service/src/main/java/com/oceanbase/odc/config/ScheduleConfiguration.java
Outdated
Show resolved
Hide resolved
...ervice/src/main/java/com/oceanbase/odc/service/structurecompare/StructureComparisonTask.java
Outdated
Show resolved
Hide resolved
PeachThinking
force-pushed
the
feat/jingtian_424_structure_compare_access_to_flowable_layer
branch
from
February 7, 2024 07:42
e03845e
to
bac18ac
Compare
yhilmare
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
yhilmare
deleted the
feat/jingtian_424_structure_compare_access_to_flowable_layer
branch
February 7, 2024 08:51
fix by #1473 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-feature
module-structure-comaprison
What this PR does / why we need it:
structure comparison access to flowable layer: implement
DBStructureComparisonFlowableTask
to create a structure comparison task.FlowInstanceController#getDownloadUrl
adapted for downloading sql script generated by structure-comparison task.structure comparison storage layer implementation.
add
DefaultDBStructureComparatorTest
for ob oracle mode.Fix several ob oracle generate update table ddl bug:
HASH
andKEY
paritition type which do not needDBTablePartitionEditor#appendDefinitions
, correct ddl is like:DBTableStructureComparator#copySourceTable
not null check constraints
which will be compared in column comparison in oracle mode. seeDBTableStructureComparator#filterNotNullCheckConstraint
Map<String, List<DBTableConstraint>> listTableConstraints(String schemaName)
only get one constraint in ob oracle mode .DBSchemaAccessor#getTables
.OBMySQLSchemaAccessor
as a public method.OracleSchemaAccessor
as a public method:Which issue(s) this PR fixes:
Fixes #816
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: