Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(osc): fix create osc task ddl contains unique key but oms precheck table not found #165

Merged

Conversation

krihy
Copy link
Collaborator

@krihy krihy commented Sep 5, 2023

What type of PR is this?

type-debug
module-online schema change

What this PR does / why we need it:

Create osc task contains ddl unique key but oms precheck table not found, because oms check unique key must be not nullable

Which issue(s) this PR fixes:

The action check table contains primary key or not nullable unique key put in odc side, create project parameter tableCategory set all, so oms precheck will be succeed

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@krihy krihy added type-bug Something isn't working priority-high module-Online schema change Online schema change labels Sep 5, 2023
@krihy krihy added this to the ODC 4.2.1 milestone Sep 5, 2023
@krihy krihy self-assigned this Sep 5, 2023
Copy link
Collaborator

@PeachThinking PeachThinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krihy krihy merged commit e89e447 into oceanbase:dev/4.2.1 Sep 5, 2023
6 checks passed
@krihy krihy deleted the yaobin_fix_osc_unique_key_table_not_found branch September 5, 2023 13:43
yhilmare pushed a commit that referenced this pull request Jan 15, 2024
…k table not found (#165)

* valid nullable unique key

* 1.modify uk check failed 18n error message

* 1.method rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module-Online schema change Online schema change priority-high type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants