Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pl-debug): add exception prompt when debugging errors #168

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

yhilmare
Copy link
Contributor

@yhilmare yhilmare commented Sep 5, 2023

What type of PR is this?

type-bug
module-PL debugger

What this PR does / why we need it:

this pr throw an exception when failed to starting debugging which gives a clear error information.

Which issue(s) this PR fixes:

Fixes #162
Close #162

Special notes for your reviewer:

Executing and debugging an anonymous block inside an anonymous block fails because there is a '/' at the end of the anonymous block, which causes a syntax error.

This is not a problem in itself, because the anonymous block window is designed not to split sentences, causing the '/' at the end of the anonymous block to be sent to the server for execution.

The problem is that when the debugging failed, the user was not informed of the specific cause of the failure. This PR will inform the user of the specific cause of the error

Additional documentation e.g., usage docs, etc.:


Copy link
Contributor

@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhilmare yhilmare merged commit 1b1a95d into dev/4.2.1 Sep 6, 2023
10 checks passed
@yhilmare yhilmare deleted the fix/anonymout_bk_debug branch September 6, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: failed to debug and execute an anonymous block ending with '/' at anonymous block window
2 participants