Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(osc): fix old running task throw npe when enable full verify #173

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

krihy
Copy link
Collaborator

@krihy krihy commented Sep 6, 2023

What type of PR is this?

type-bug
module-online schema change

What this PR does / why we need it:

log password and check full verify result cause npe

Which issue(s) this PR fixes:

  1. fix check full verify result may cause npe when verify result is not arrived
  2. fix clean up password in log when request oms create datasource failed

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@krihy krihy added type-bug Something isn't working priority-high module-Online schema change Online schema change labels Sep 6, 2023
@krihy krihy added this to the ODC 4.2.1 milestone Sep 6, 2023
@krihy krihy self-assigned this Sep 6, 2023
Copy link
Contributor

@smallsheeeep smallsheeeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krihy krihy merged commit 19cfec0 into oceanbase:dev/4.2.1 Sep 6, 2023
6 checks passed
@krihy krihy deleted the yaobin_fix_full_verify_npe branch September 6, 2023 05:44
yhilmare pushed a commit that referenced this pull request Jan 15, 2024
* 1.fix oms check data inconsistent, osc task not failed
2.clean up password in log when create oms log failed

* cleanUpSensitiveMsgInRequest

* optimize log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module-Online schema change Online schema change priority-high type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants