fix(data-security): create sensitive columns with case insensitive same column and table names #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallsheeeep
added
type-bug
smallsheeeep
requested review from
yhilmare,
MarkPotato777,
krihy and
yizhouxw
Done! |
smallsheeeep
deleted the
bugfix/gaoda_421_fix_case_insensitive_columns
branch
yhilmare
pushed a commit
that referenced
this pull request
Jan 15, 2024
…me column and table names (#175) * fix: create duplicated sensitive columns * fix: import sort * fix: scan duplicated sensitive columns * add: unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
module-Data security
What this PR does / why we need it:
The ODC metaDB is case insensitive when calculating unique key. So, if there are two columns with the case insensitive same table name and column name, and add both of them to sensitive columns, exception will be throw.
Solution: Make sensitive columns case insensitive. if there are two columns with the case insensitive same table name and column name, then they cannot be both add to sensitive columns.
Which issue(s) this PR fixes:
Fixes #161