Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connection): supports query connections by username #1981

Merged
merged 15 commits into from
Apr 3, 2024

Conversation

PeachThinking
Copy link
Collaborator

@PeachThinking PeachThinking commented Mar 20, 2024

What type of PR is this?

type-feature

What this PR does / why we need it:

  1. support query connections by username
  2. build LoadingCache<Long, UserEntity> id2UserEntity in DatabaseSyncManager because the multi-cloud synchronization database relies on accountName.
  3. OBInstanceStatus and OBInstanceType is odc 413bp10 bugfix: adaption for ocp internal interface

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@PeachThinking PeachThinking added the type-feature The functionality to be implemented label Mar 20, 2024
@PeachThinking PeachThinking added this to the ODC 4.3.0 milestone Mar 20, 2024
@PeachThinking PeachThinking self-assigned this Mar 20, 2024
@PeachThinking PeachThinking changed the title [WIP]feat(multi-cloud): sql console for multi-cloud [WIP]feat(connection): support query connections by username Mar 20, 2024
@PeachThinking PeachThinking force-pushed the feat/jingtian_multicloud_202404_sql_console branch from 0295f50 to 7531942 Compare March 21, 2024 09:23
@PeachThinking PeachThinking force-pushed the feat/jingtian_multicloud_202404_sql_console branch from 7531942 to 09be489 Compare March 22, 2024 03:22
@PeachThinking PeachThinking force-pushed the feat/jingtian_multicloud_202404_sql_console branch from f796d37 to 9c9935f Compare March 28, 2024 02:17
@PeachThinking PeachThinking force-pushed the feat/jingtian_multicloud_202404_sql_console branch from 9c9935f to f7e86a5 Compare March 29, 2024 02:20
@PeachThinking PeachThinking force-pushed the feat/jingtian_multicloud_202404_sql_console branch from 1be44b2 to 79eaa95 Compare April 1, 2024 06:52
@PeachThinking PeachThinking changed the title [WIP]feat(connection): support query connections by username feat(connection): support query connections by username Apr 1, 2024
@PeachThinking PeachThinking force-pushed the feat/jingtian_multicloud_202404_sql_console branch from a774caf to 34b954d Compare April 1, 2024 10:00
yhilmare
yhilmare previously approved these changes Apr 2, 2024
Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

yizhouxw
yizhouxw previously approved these changes Apr 2, 2024
Copy link
Contributor

@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PeachThinking PeachThinking dismissed stale reviews from yizhouxw and yhilmare via f0a464b April 2, 2024 11:49
yizhouxw
yizhouxw previously approved these changes Apr 2, 2024
@PeachThinking PeachThinking changed the base branch from dev/4.2.x to dev/4.2.4 April 3, 2024 02:45
@PeachThinking PeachThinking dismissed yizhouxw’s stale review April 3, 2024 02:45

The base branch was changed.

@yhilmare yhilmare deleted the branch dev/4.2.x April 3, 2024 03:13
@yhilmare yhilmare closed this Apr 3, 2024
@yhilmare yhilmare reopened this Apr 3, 2024
@yhilmare yhilmare modified the milestones: ODC 4.3.0, ODC 4.2.4 Apr 3, 2024
@yhilmare yhilmare changed the base branch from dev/4.2.4 to dev/4.2.x April 3, 2024 06:11
@yhilmare yhilmare changed the title feat(connection): support query connections by username feat(connection): supports query connections by username Apr 3, 2024
Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 662d9a1 into dev/4.2.x Apr 3, 2024
11 checks passed
@yhilmare yhilmare deleted the feat/jingtian_multicloud_202404_sql_console branch April 3, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-feature The functionality to be implemented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants